Remove the Terraform CLI from the provider package and deprecate the relevant provider command-line flags. #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…relevant provider command-line flags. - Increase the default value `--max-reconcile-rate` from 10 to 100 - Deprecate the following provider command-line flags: - terraform-version - terraform-provider-version - terraform-native-provider-path - terraform-provider-source - provider-ttl Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/azure/resourcegroup.yaml" |
|
/test-examples="examples/network/subnet.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
With #592, we have switched to the Terraform plugin SDK-based reconciliation for all the available managed resources in this provider. This PR removes the Terraform CLI and the Terraform Azure provider binaries from the built provider package. We still need to generate the
config/schema.jsonfor diff detection purposes and for the code generation pipeline, and we are planning to address the issue of generating theschema.jsonwithout the TF CLI in a follow-up PR.We are also deprecating the following process-forking related command-line arguments:
terraform-versionterraform-provider-versionterraform-native-provider-pathterraform-provider-sourceprovider-ttlWhat the user will see in the provider logs if she uses any of these flags is something like the following:
These logs will be available even if the
debuglogging is not enabled for the provider.This PR also bumps the
--max-reconcile-ratecommand-line option's default to 100 to leverage the SDK-based reconciliation runtime's performance improvements.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Via an uptest run and manually with the package
index.docker.io/ulucinar/provider-family-azure:v0.41.0-4e29a7c1ef8506fac221064410b799888fbfd10c.