Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-0.42] Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependiencies #657

Merged

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Feb 22, 2024

Description of your changes

In this PR:

  • Switch from the NoFork terminology to the TerraformPluginSDK terminology
  • Bump crossplane-runtime version to v1.15.1
  • Bump upjet version to v1.1.1

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

…ogy and bump dependiencies

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf turkenf force-pushed the release-0.42-bump-dependencies branch from 52a5091 to 433abb8 Compare February 22, 2024 10:17
@turkenf turkenf changed the title [Backport release-0.42]Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependiencies [Release-0.42] Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependiencies Feb 22, 2024
@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/azure/resourcegroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/network/subnet.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/containerservice/kubernetescluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/cdn/endpoint.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/dbformysql/database.yaml"

@turkenf turkenf marked this pull request as ready for review February 22, 2024 13:29
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm. Let's fix the versions to the ones already defined in go.mod:

replace golang.org/x/exp => golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa

replace github.com/hashicorp/terraform-json => github.com/hashicorp/terraform-json v0.16.0

replace github.com/hashicorp/terraform-plugin-sdk/v2 => github.com/hashicorp/terraform-plugin-sdk/v2 v2.26.1

replace github.com/hashicorp/terraform-plugin-go => github.com/hashicorp/terraform-plugin-go v0.14.3

Let's also run at least one uptest again after these dependency changes.

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/azure/resourcegroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/network/subnet.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/containerservice/kubernetescluster.yaml"

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf turkenf force-pushed the release-0.42-bump-dependencies branch from 74013b5 to 3b84a77 Compare February 22, 2024 15:34
@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/azure/resourcegroup.yaml"

Uptest run: https://github.com/upbound/provider-azure/actions/runs/8007139513

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/network/subnet.yaml"

Uptest run: https://github.com/upbound/provider-azure/actions/runs/8007142159

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 22, 2024

/test-examples="examples/containerservice/kubernetescluster.yaml"

Uptest run: https://github.com/upbound/provider-azure/actions/runs/8007145087

@turkenf turkenf merged commit a21a542 into crossplane-contrib:release-0.42 Feb 22, 2024
12 checks passed
@turkenf turkenf deleted the release-0.42-bump-dependencies branch February 22, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants