Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azurerm_cognitive_deployment resource #706

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

mirza-src
Copy link
Contributor

@mirza-src mirza-src commented Apr 10, 2024

Description of your changes

Added azurerm_cognitive_deployment resource.
Changed azurerm_cognitive_account ExternalName from TemplatedStringAsIdentifier to IdentifierFromProvider for the azurerm_cognitive_deployment to work.

Fixes #704

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Signed-off-by: Mirza Esaaf Shuja <mirzaesaaf@gmail.com>
Signed-off-by: Mirza Esaaf Shuja <mirzaesaaf@gmail.com>
Signed-off-by: Mirza Esaaf Shuja <mirzaesaaf@gmail.com>
Signed-off-by: Mirza Esaaf Shuja <mirzaesaaf@gmail.com>
…xample

Signed-off-by: Mirza Esaaf Shuja <mirzaesaaf@gmail.com>
@jeanduplessis
Copy link
Collaborator

/test-examples="examples/cognitiveservices/deployment.yaml"

@mirza-src
Copy link
Contributor Author

mirza-src commented Apr 11, 2024

@jeanduplessis Just noticed Quota Issue in the subscription configured for uptest.

Account Name: "example-ca"): unexpected status 400 with error: SpecialFeatureOrQuotaIdRequired: The subscription does not have QuotaId/Feature required by SKU 'S0' from kind 'OpenAI' or contains blocked QuotaId/Feature.  []***]

Currently Azure requires registration (docs) for Azure OpenAI Service. Can that be submitted for the subscription used in uptest, so that the e2e test can proceed?

@jeanduplessis
Copy link
Collaborator

@mirza-src let me see if I can get that service activated on our test account.

@jeanduplessis
Copy link
Collaborator

/test-examples="examples/cognitiveservices/deployment.yaml"

@jeanduplessis
Copy link
Collaborator

@mirza-src let me see if I can get that service activated on our test account.

The services have been activated on our test account now. Re-running the e2e.

@mirza-src
Copy link
Contributor Author

@jeanduplessis, I was looking at the code and think that changing ExternalName from TemplatedStringAsIdentifier to IdentifierFromProvider may have worked but is probably not the best was thinking of reverting it before the merge maybe (just passed the e2e tests locally)?

This reverts commit 1a71371.

Signed-off-by: Mirza Esaaf Shuja <mirzaesaaf@gmail.com>
Signed-off-by: Mirza Esaaf Shuja <mirzaesaaf@gmail.com>
@mirza-src
Copy link
Contributor Author

/test-examples="examples/cognitiveservices/deployment.yaml"

@jeanduplessis
Copy link
Collaborator

@mirza-src since this is your first PR you don't yet have the capability to trigger an e2e test. Once this PR is merged you'll be seen as a collaborator and then have the ability to trigger it.

@jeanduplessis
Copy link
Collaborator

/test-examples="examples/cognitiveservices/deployment.yaml"

@jeanduplessis
Copy link
Collaborator

@mirza-src looking good with the latest change. The maintainers are back next week and I'll ask them to give the PR a once-over before it gets merged.

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your effort @mirza-src, lgtm.

@turkenf turkenf merged commit ddd0c93 into crossplane-contrib:main Apr 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for azurerm_cognitive_deployment resource
3 participants