Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependencies #100

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependencies #100

merged 2 commits into from
Feb 23, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Feb 21, 2024

Description of your changes

In this PR:

  • Switch from the NoFork terminology to the TerraformPluginSDK terminology
  • Bump crossplane-runtime version to v1.15.1
  • Bump upjet version to v1.1.1

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Tested with uptest below

@turkenf
Switch from the NoFork terminology to the TerraformPluginSDK terminol…
6836598 
…ogy and bump dependiencies

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Feb 21, 2024 •
edited

/test-examples="examples/applications/application.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/7989775621

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 21, 2024 •
edited

/test-examples="examples/conditionalaccess/accesspolicy.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/7989815803

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 21, 2024 •
edited

/test-examples="examples/groups/member.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/7989817936

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 21, 2024 •
edited

/test-examples="examples/serviceprincipals/principal.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/7989820059

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 21, 2024 •
edited

/test-examples="examples/applications/federatedidentitycredential.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/7989821991

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 21, 2024 •
edited

/test-examples="examples/conditionalaccess/location.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/7989823999

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 21, 2024 •
edited

/test-examples="examples/serviceprincipals/certificate.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/7989825686

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 21, 2024 •
edited

/test-examples="examples/synchronization/secret.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/7989827496

sergenyalcin
sergenyalcin approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf LGTM! Please see @ulucinar's comment about fixing the dependencies.

@turkenf
go.mod fixes mentioned in the review comment
ae44a13 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Feb 23, 2024 •
edited

/test-examples="examples/applications/application.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8015413248

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 23, 2024 •
edited

/test-examples="examples/serviceprincipals/principal.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8015415921

@turkenf
Copy link
Collaborator Author

turkenf commented Feb 23, 2024 •
edited

/test-examples="examples/synchronization/secret.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/8015418554

@turkenf turkenf merged commit 931822f into crossplane-contrib:main Feb 23, 2024
12 checks passed
@turkenf turkenf deleted the bump-upjet-v1.1.1 branch February 23, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergenyalcin sergenyalcin sergenyalcin approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turkenf @sergenyalcin