Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Pluggable External Secret Store functionality #51

Merged
merged 1 commit into from
May 11, 2023

Conversation

ezgidemirel
Copy link
Contributor

Description of your changes

With this PR, we're consuming latest Upjet changes and loading TLS configuration which will be used by Pluggable Secret Store integration.

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Tested e2e with the following manifests:

apiVersion: applications.azuread.upbound.io/v1beta1
kind: Password
metadata:
  annotations:
    meta.upbound.io/example-id: applications/v1beta1/password
  labels:
    testing.upbound.io/example-name: example
  name: ezgi-app-ess-pswd
spec:
  forProvider:
    applicationObjectIdSelector:
      matchLabels:
        testing.upbound.io/example-name: example-ezgi
  publishConnectionDetailsTo:
    name: ess-mr-conn
    configRef:
      name: vault

---

apiVersion: applications.azuread.upbound.io/v1beta1
kind: Application
metadata:
  annotations:
    meta.upbound.io/example-id: applications/v1beta1/password
  labels:
    testing.upbound.io/example-name: example-ezgi
  name: ezgi-app-ess
spec:
  forProvider:
    displayName: ezgi-app-ess

Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
@ezgidemirel
Copy link
Contributor Author

/test-examples="examples/applications/password.yaml"

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezgidemirel, lgtm.

@ezgidemirel ezgidemirel merged commit 390d3b7 into crossplane-contrib:main May 11, 2023
10 checks passed
@ezgidemirel ezgidemirel deleted the enable-ess branch May 11, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants