Enforce maximum allowed Terraform version #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Watts <jbw976@gmail.com>
Signed-off-by: Jared Watts <jbw976@gmail.com>
Signed-off-by: Jared Watts <jbw976@gmail.com>
jbw976
commented
Jun 5, 2024
|
Nice to see all the PR checks green ✅ on the first try 😂 |
yordis
reviewed
Jun 5, 2024
yordis
approved these changes
Jun 5, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR applies the changes from crossplane/upjet-provider-template#67 to this repository.
In the Crossplane project, we cannot use a version of Terraform greater than v1.5.x because of the not permitted BSL license that was introduced starting with v1.6.0.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I have tested locally that the build still completes successful with
makeandmake reviewablestill passes all tests/checks. Of particular note is that no CRD schemas are affected by this change.I would appreciate a critical look here to see if there's more manual testing we can perform to validate this change, as I am rolling this out across a number of providers I'm not super familiar with 😇