Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add project shared vpc resources selectors #210

Conversation

bradkwadsworth-mw
Copy link
Contributor

@bradkwadsworth-mw bradkwadsworth-mw commented Feb 3, 2023

Description of your changes

Enabled google_compute_shared_vpc_host_project and google_compute_shared_vpc_service_project. It would appear that google_compute_shared_vpc_service_project requires the google-beta provider in order to work in some situations such as when the Shared VPC Admin role is set at the folder level. Has there been an discussion on creating another Upjet provider based on the google-beta Terraform provider?
Added host project and service project selectors for SharedVPCHostProject and SharedVPCServiceProject resources.

Fixes #80

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested the creation of a GCP project and enabled that project as a VPC host project. Also created a service project and attached it to the host project.
Screenshot 2023-03-31 at 11 14 57 AM

@bradkwadsworth-mw bradkwadsworth-mw force-pushed the feature/add-project-shared-vpc-resources branch 2 times, most recently from c949ae9 to 94d8f62 Compare February 8, 2023 17:30
@turkenf
Copy link
Collaborator

turkenf commented Mar 14, 2023

Required status checks have been changed, could you please rebase this PR?

@sergenyalcin
Copy link
Collaborator

/test-examples="examples/compute/sharedvpchostproject.yaml"

1 similar comment
@bradkwadsworth-mw
Copy link
Contributor Author

/test-examples="examples/compute/sharedvpchostproject.yaml"

@bradkwadsworth-mw bradkwadsworth-mw force-pushed the feature/add-project-shared-vpc-resources branch from 4a4f20d to 546a5e6 Compare May 11, 2023 14:39
@bradkwadsworth-mw bradkwadsworth-mw changed the title Feature/add project shared vpc resources Feature/add project shared vpc resources selectors May 15, 2023
Signed-off-by: Brad Wadsworth <brad.wadsworth@mavenwave.com>
Signed-off-by: Brad Wadsworth <brad.wadsworth@mavenwave.com>
Signed-off-by: Brad Wadsworth <brad.wadsworth@mavenwave.com>
Signed-off-by: Brad Wadsworth <brad.wadsworth@mavenwave.com>
Signed-off-by: Brad Wadsworth <brad.wadsworth@mavenwave.com>
Signed-off-by: Brad Wadsworth <brad.wadsworth@mavenwave.com>
@bradkwadsworth-mw bradkwadsworth-mw force-pushed the feature/add-project-shared-vpc-resources branch from 546a5e6 to afe2e2f Compare May 15, 2023 16:47
@turkenf
Copy link
Collaborator

turkenf commented Jun 8, 2023

Closing & reopening to trigger the Github workflow runs.

@turkenf turkenf closed this Jun 8, 2023
@turkenf turkenf reopened this Jun 8, 2023
@turkenf
Copy link
Collaborator

turkenf commented Jun 8, 2023

/test-examples="examples/compute/sharedvpchostproject.yaml"

Copy link
Collaborator

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resources in this PR require manual intervention, i.e. privileged access in multiple gcp projects, so ignoring failing uptest runs. I am not sure why it failed despite themanual-internvention annotation, though.

@turkenh turkenh merged commit 93fb74a into crossplane-contrib:main Jun 9, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving compute (2) resources to v1beta1 version
4 participants