-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples for bigtable(4) resources #287
Conversation
/test-examples="examples/bigtable/tableiambinding.yaml" |
/test-examples="examples/bigtable/tableiambinding.yaml" |
1 similar comment
/test-examples="examples/bigtable/tableiambinding.yaml" |
/test-examples="examples/bigtable/tableiammember.yaml" |
/test-examples="examples/bigtable/tableiambinding.yaml" |
/test-examples="examples/bigtable/tableiammember.yaml" |
/test-examples="examples/bigtable/instanceiambinding.yaml" |
/test-examples="examples/bigtable/instanceiammember.yaml" |
…ing & InstanceIAMBinding to check-examples.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turkenf, lgtm.
Description of your changes
This PR adds examples of the following 4 resources in the bigtable group:
Fixes: #280
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
google_bigtable_table_iam_member
,M, U(https://github.com/upbound/provider-gcp/actions/runs/4798329208)google_bigtable_instance_iam_member
,M, U(https://github.com/upbound/provider-gcp/actions/runs/4798656521)google_bigtable_table_iam_binding
,M, U(https://github.com/upbound/provider-gcp/actions/runs/4798116205)google_bigtable_instance_iam_binding
,M, U(https://github.com/upbound/provider-gcp/actions/runs/4798539930)