Rename family parent package from provider-gcp-config to provider-family-gcp #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezgidemirel
reviewed
May 16, 2023
| @@ -23,6 +23,6 @@ metadata: | |||
| {{ if and (ne .Service "config") (ne .Service "monolith") -}} | |||
| spec: | |||
| dependsOn: | |||
| - provider: {{ .XpkgRegOrg }}/provider-{{ .ProviderName }}-config | |||
| - provider: {{ .XpkgRegOrg }}/provider-family-{{ .ProviderName }} | |||
There was a problem hiding this comment.
I believe we should also update the label value
There was a problem hiding this comment.
Thanks for the catch. We had better parameterize the family parent repo name at some point I guess :)
…ily-gcp Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
rename-config-package
branch
from
9a2ec31
to
6e35114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR proposes a renaming of the family parent package from
provider-gcp-configtoprovider-family-gcp.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Validated in crossplane-contrib/provider-upjet-azure#452.