Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issue in docs for creating a Cronjob for rotate the GCP access tokens #310

Merged
merged 1 commit into from
May 23, 2023

Conversation

rbrunan
Copy link
Contributor

@rbrunan rbrunan commented May 23, 2023

Description of your changes

This is only a documentation change, with the current guide, I obtained an error running the Job:

kubectl logs -n crossplane cred-sync-001-tc4xk                                                                                                   ─╯
/bin/bash: -c: line 3: syntax error near unexpected token `('

This was fixed with the proposed change.

How has this code been tested

I tested the proposed change in a test GCP cluster running k8s v1.24.11.

@Upbound-CLA
Copy link

Upbound-CLA commented May 23, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@jeanduplessis jeanduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @rbrunan

@jeanduplessis jeanduplessis merged commit b860885 into crossplane-contrib:main May 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants