-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the required field spec.projectID
for ProviderConfig creation …
#320
Adds the required field spec.projectID
for ProviderConfig creation …
#320
Conversation
…in Upbound Signed-off-by: Jason Tang <jason@upbound.io>
There are some documentation improvements that we can make here before we merge. However, I was able to confirm that the control plane is successfully provisioning external infrastructure in GCP. |
Signed-off-by: Jason Tang <jason@upbound.io>
@@ -33,6 +33,7 @@ sources: | |||
ref: spec.credentials.secretRef | |||
showFields: | |||
- spec.credentials.secretRef | |||
- spec.projectID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ulucinar @sergenyalcin for context, this and L93 is the core fix.
Everything else is a quick refresh of the configurable documentation in that this enables in the Console - I acknowledge that the content is not optimal, but addresses some gaps in the OIDC configuration process for the user which we will iterate on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jastang.
Successfully created backport PR #322 for |
…in Upbound
Description of your changes
In Upbound,
package/auth.yaml
is used to configure what fields are exposed to createProviderConfig
objects. The required fieldspec.projectID
was missing for GCP.-->
Fixes #https://github.com/upbound/squad-upbound-cloud/issues/1248
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested