Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump upjet to the commit 4cb45f9104ac #439

Merged
merged 1 commit into from Dec 28, 2023

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Dec 28, 2023

Description of your changes

This PR bumps the upjet to the commit 4cb45f9104ac with @sergenyalcin's changes addressing crossplane/upjet#307 and adds the referencer fields under to spec.initProvider.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

This change was tested in this PR and with uptest below.

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Dec 28, 2023

/test-examples="examples/cloudplatform/serviceaccount.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf LGTM!

@turkenf turkenf merged commit bbbb309 into crossplane-contrib:main Dec 28, 2023
10 checks passed
@turkenf turkenf deleted the bump-upjet-4cb45f9104ac branch December 28, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants