Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependiencies #461

Merged
merged 3 commits into from Feb 26, 2024

Conversation

sergenyalcin
Copy link
Collaborator

@sergenyalcin sergenyalcin commented Feb 21, 2024

Description of your changes

In this PR:

  • Switch from the NoFork terminology to the TerraformPluginSDK terminology
  • Bump crossplane-runtime version to v1.15.1
  • Bump upjet version to v1.1.1

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

NAME                                            READY   SYNCED   EXTERNAL-NAME
                                     AGE
connection.bigquery.gcp.upbound.io/connection   True    True     projects/official-provider-testing/locations/US/connections/31
8e9757-4747-4f89-98e4-a144e20cfec7   47m

NAME                             READY   SYNCED   EXTERNAL-NAME   AGE
database.sql.gcp.upbound.io/db   True    True     db              47m

NAME                                                          READY   SYNCED   EXTERNAL-NAME             AGE
databaseinstance.sql.gcp.upbound.io/example-instance-test12   True    True     example-instance-test12   58m

NAME                           READY   SYNCED   EXTERNAL-NAME   AGE
user.sql.gcp.upbound.io/user   True    True     user            47m

…ogy and bump dependiencies

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Feb 21, 2024

/test-examples="examples/redis/instance.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Feb 21, 2024

/test-examples="examples/compute/network.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Feb 21, 2024

/test-examples="examples/compute/route.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Feb 21, 2024

/test-examples="examples/cloudplatform/serviceaccount.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Feb 21, 2024

/test-examples="examples/bigquery/connection.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Feb 21, 2024

/test-examples="examples/storage/bucketobject.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Feb 21, 2024

/test-examples="examples/bigquery/connection.yaml"

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Feb 21, 2024

/test-examples="examples/bigquery/connection.yaml"

@turkenf turkenf marked this pull request as ready for review February 21, 2024 21:16
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sergenyalcin, LGTM.

go.mod Outdated Show resolved Hide resolved
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin sergenyalcin merged commit 7953bd6 into crossplane-contrib:main Feb 26, 2024
9 checks passed
@sergenyalcin sergenyalcin deleted the update-deps branch February 26, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants