Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.0] Set log.Default's output to io.Discard #480

Merged
merged 1 commit into from Mar 14, 2024

Conversation

github-actions[bot]
Copy link

Description

Backport of #479 to release-1.0.

@ulucinar
Copy link
Collaborator

/test-examples="examples/pubsub/topic.yaml"

@ulucinar
Copy link
Collaborator

Closing & reopening to trigger the CI pipeline runs...

@ulucinar ulucinar closed this Mar 14, 2024
@ulucinar ulucinar reopened this Mar 14, 2024
if debug logging is not enabled.

- Set log.Default's output to io.Discard.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
(cherry picked from commit 0d15fd4)
@ulucinar ulucinar force-pushed the backport-479-to-release-1.0 branch from 8ae4466 to e46fe8f Compare March 14, 2024 13:07
@ulucinar
Copy link
Collaborator

/test-examples="examples/pubsub/topic.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ulucinar ulucinar merged commit 17635b9 into release-1.0 Mar 14, 2024
9 of 10 checks passed
@ulucinar ulucinar deleted the backport-479-to-release-1.0 branch March 14, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants