Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate license headers for setup.go files by consuming the upjet 1.1.5 #486

Merged

Conversation

sergenyalcin
Copy link
Collaborator

@sergenyalcin sergenyalcin commented Mar 15, 2024

Description of your changes

This PR generates license headers for setup.go files by consuming the upjet 1.1.5. More details please see crossplane/upjet#376.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Uptest Run: https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/8293779286

….1.5`

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin
Copy link
Collaborator Author

/test-examples="examples/cloudplatform/serviceaccount.yaml"

@sergenyalcin sergenyalcin changed the title Generate license headers for setup.go fiels by consuming the upjet 1.1.5 Generate license headers for setup.go files by consuming the upjet 1.1.5 Mar 15, 2024
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sergenyalcin, lgtm.

@sergenyalcin sergenyalcin merged commit 4299d6f into crossplane-contrib:main Mar 15, 2024
10 checks passed
@sergenyalcin sergenyalcin deleted the generate-setup-licenses branch March 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants