ManagedZone - Use selflink for peer_config and private_visibility_config #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oskisk
force-pushed
the
managedZone-selfLink
branch
2 times, most recently
from
e9b7a22
to
a08c4b7
Compare
oskisk
changed the title
Signed-off-by: Armin Barton <ab5@xxxlgroup.com>
oskisk
force-pushed
the
managedZone-selfLink
branch
from
52f5de6
to
d8098c9
Compare
sergenyalcin
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Uses a networkSelectors with the selfLinkExtractor to the ManagedZone. This change is needed to get the ManagedZone working with a shared vpc setup.
Fixes #64
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested manually, created a managed zone with the new selectors with networks in a different project.