RegionTargetHTTPProxy - Use selflink for resolving RegionURLMap #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/compute/regiontargethttpproxy.yaml" |
ulucinar
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Thank you @Pocokwins for the PR, lgtm. Also successfully verified the change via uptest with the comment above (the provided example manifest in the repo contains the affected reference).
oskisk
deleted the
RegionTargetHTTPProxy_Use-selflink-instead-of-resourceId
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Use selflink to resolve RegionURLMap instead of resource id.
Fixes #82
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I've tested it manually by creating a new RegionTargetHTTPProxy, which managed to resolve the correct RegionURLMap with the urlMapSelector without hardcoding it's resource ID.