Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to crossplane/crossplane #20

Closed
maximilianbraun opened this issue Nov 17, 2023 · 0 comments · Fixed by #22
Closed

Remove dependency to crossplane/crossplane #20

maximilianbraun opened this issue Nov 17, 2023 · 0 comments · Fixed by #22

Comments

@maximilianbraun
Copy link
Collaborator

Context & Problem Statement

Today, xp-testing uses types from crossplane/crossplane. This results into a set of transitive dependencies which can make it hard to integrate with providers.

Proposal

Remove the dependency to crossplane/crossplane by replacing the use of the Types with either mirroring types. E.g. ControllerConfig is part of the API xp-testing is explosing. Where we use, e.g. Provider type we could go with unstructured clients.

maximilianbraun added a commit that referenced this issue Nov 24, 2023
fixes #20 

One caveat: we had to vendor the type for controller config. in a follow
up, we should already enable the new type for that, the same way, but
maybe better then with automatically copying… Or we just let the user
create a the controller config (or future thing) and patch the
unstructured.

Additionally we got rid of the controller-runtime dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant