Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: raise e2e-framework to v0.3.0 #3

Merged
merged 8 commits into from
Nov 15, 2023
Merged

feat: raise e2e-framework to v0.3.0 #3

merged 8 commits into from
Nov 15, 2023

Conversation

maximilianbraun
Copy link
Collaborator

@maximilianbraun maximilianbraun commented Nov 13, 2023 •
edited

Raising deps e2e-framework to v.0.3.0 and Crossplane to v.1.14.0

e2e-framwork v0.3.0 enables more cluster providers, this is currently not partially supported, since some setup functions have the assumption that we run on kind. The default setup hints into that direction.

Additionally:

  • Added an e2e test with provider-nop
  • Added a method to register Cluster Name aware functions which run after cluster creation
  • Renamed a couple of functions, to make clear they run on with kind
  • Where possible removed the kind assumptions
  • Removed a duplicate function for exporting the clusters logs
  • Make the k8s.Object for features optional.

@maximilianbraun
feat: raise e2e-framework to v0.3.0
8eed6ce 
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
@maximilianbraun
replace deprecated function use
be8c1d1 
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
@maximilianbraun
make use of new export logs function
3ccdcc6 
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
@maximilianbraun
Merge branch 'main' into feat/e2e-upgrade
71beaf6 
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
@maximilianbraun
test: add e2e test with provider-nop
571d4ed 
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
@maximilianbraun
chore: ignore logs written while test run
66820c4 
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
@maximilianbraun
chore: fix up example
8748ea1 
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
@maximilianbraun
lint
46dc794 
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
mirzakopic
mirzakopic approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@mirzakopic mirzakopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left a comment about versioning.

pkg/resources/resources.go Show resolved Hide resolved
@maximilianbraun maximilianbraun merged commit 36acfce into main Nov 15, 2023
6 checks passed
@maximiliantech maximiliantech deleted the feat/e2e-upgrade branch February 11, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirzakopic mirzakopic mirzakopic approved these changes

@haarchri haarchri Awaiting requested review from haarchri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maximilianbraun @mirzakopic