-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pkg/util #1
Labels
enhancement
New feature or request
Comments
This was referenced Aug 21, 2019
4 tasks
This was referenced Dec 6, 2019
negz
added a commit
to negz/crossplane
that referenced
this issue
Jan 31, 2020
crossplane/crossplane-runtime#1 Per the above issue the util package is deprecated. As best I can tell the stacks package is the only user of these functions, so I suggest they live where they're used. Signed-off-by: Nic Cope <negz@rk0n.org>
4 tasks
negz
added a commit
to negz/provider-azure
that referenced
this issue
Jan 31, 2020
crossplane/crossplane-runtime#1 Per the above issue the util package is deprecated. As best I can tell the AKS cluster controller is the only user of this retry setting, so suggest we move it to where it's used. Signed-off-by: Nic Cope <negz@rk0n.org>
4 tasks
negz
added a commit
to negz/provider-aws
that referenced
this issue
Jan 31, 2020
crossplane/crossplane-runtime#1 Per the above issue the utils package is deprecated. As best I can tell these are the only uses of these functions, which duplicate existing client functions. Signed-off-by: Nic Cope <negz@rk0n.org>
4 tasks
negz
added a commit
to negz/provider-azure
that referenced
this issue
Jan 31, 2020
crossplane/crossplane-runtime#1 Per the above issue the util package is deprecated. As best I can tell this is the only use of this very simple function, so I've inlined it. Signed-off-by: Nic Cope <negz@rk0n.org>
negz
added a commit
to negz/crossplane-runtime
that referenced
this issue
Jan 31, 2020
crossplane#1 Each of these functions were called by only a single package, so I've raised PRs to move them to the packages that call them. All relevant PRs are cross linked from the above issue Signed-off-by: Nic Cope <negz@rk0n.org>
As of #112 we're down to two functions left in
|
negz
added a commit
to negz/provider-azure
that referenced
this issue
Jan 31, 2020
crossplane/crossplane-runtime#1 Per the above issue the util package is deprecated. As best I can tell this is the only use of this very simple function, so I've rehomed it. Signed-off-by: Nic Cope <negz@rk0n.org>
negz
added a commit
to negz/crossplane-runtime
that referenced
this issue
Jan 31, 2020
crossplane#1 Each of these functions were called by only a single package, so I've raised PRs to move them to the packages that call them. All relevant PRs are cross linked from the above issue Signed-off-by: Nic Cope <negz@rk0n.org>
negz
added a commit
to negz/provider-gcp
that referenced
this issue
Jan 31, 2020
crossplane/crossplane-runtime#1 Per the above issue GeneratePassword is one of two functions that remain in our deprecated util package. I like go-password because it opens up the potential to switch to a mock implementation for testing. Signed-off-by: Nic Cope <negz@rk0n.org>
This was referenced Feb 1, 2020
Merged
wolffbe
pushed a commit
to wolffbe/provider-aws
that referenced
this issue
Feb 12, 2021
crossplane/crossplane-runtime#1 Per the above issue the utils package is deprecated. As best I can tell these are the only uses of these functions, which duplicate existing client functions. Signed-off-by: Nic Cope <negz@rk0n.org>
namku
pushed a commit
to namku/provider-aws
that referenced
this issue
Mar 9, 2021
crossplane/crossplane-runtime#1 Per the above issue the utils package is deprecated. As best I can tell these are the only uses of these functions, which duplicate existing client functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue has been created to track the work originally expressed in crossplane/crossplane#448
It's generally considered a mispattern in the Go world to create package names like
util
, orcommon
. The preferred alternatives are typically one or more of:strings
,metadata
, etc.util.ToLowerRemoveSpaces
defined closer to where they're used.Sources:
The text was updated successfully, but these errors were encountered: