Allow both resource claims and managed resources to pass the class kind predicate #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nic Cope <negz@rk0n.org>
It turns out both our watches use the same predicate and apply it to the watched kind, not the kind that actually gets enqueued. Signed-off-by: Nic Cope <negz@rk0n.org>
|
I've also run |
hasheddan
approved these changes
Sep 13, 2019
4 tasks
|
Confirmed this works by building stack-gcp against this commit and creating a |
negz
added a commit
to negz/provider-gcp
that referenced
this pull request
Sep 13, 2019
We want the fix from crossplane/crossplane-runtime#18 Signed-off-by: Nic Cope <negz@rk0n.org>
4 tasks
|
Thank you for finding this issue and getting it fixed so quickly @negz!! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
It turns out both our watches use the same predicate and apply it to the watched kind, not the kind that actually gets enqueued.
Checklist
I have:
make reviewableto ensure this PR is ready for review.clusterrole.yamlto include any new types.