Fix support for static provisioning #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controllers built against crossplane-runtime will currently panic if they encounter a managed resource without a class reference. Any dynamically provisioned managed resource will have a class reference, but this breaks the static provisioning workflow. Signed-off-by: Nic Cope <negz@rk0n.org>
negz
added a commit
to negz/provider-gcp
that referenced
this pull request
Sep 14, 2019
crossplane/crossplane-runtime#24 Use the static binding compatible predicates introduced in the above PR. Signed-off-by: Nic Cope <negz@rk0n.org>
4 tasks
This was referenced Sep 14, 2019
|
I've tested that both the static and dynamic provisioning flows work by using a build of crossplane-contrib/provider-gcp#24 to statically and then dynamically provision a |
negz
added a commit
to negz/provider-azure
that referenced
this pull request
Sep 14, 2019
crossplane/crossplane-runtime#24 Use the static provisioning compatible predicates introduced in the above PR. Signed-off-by: Nic Cope <negz@rk0n.org>
This was referenced Sep 14, 2019
negz
added a commit
to negz/provider-aws
that referenced
this pull request
Sep 14, 2019
crossplane/crossplane-runtime#24 Use the static provisioning compatible predicates introduced in the above PR. Signed-off-by: Nic Cope <negz@rk0n.org>
4 tasks
hasheddan
approved these changes
Sep 14, 2019
There was a problem hiding this comment.
Reviewed in conjunction with crossplane-contrib/provider-gcp#24. LGTM!
jbw976
reviewed
Sep 14, 2019
We currently support dynamic provisioning in the resource claim reconciler by using a watch predicate that allows either managed resources that directly reference a non-portable resource class of a given kind, or resource claims that reference a non-portable resource class of a given kind indirectly via a portable resource class. To support static provisioning (i.e. explicitly claiming an existing managed resource) we must also allow resource claims that explicitly reference a managed resource. Writing one predicate to do all of this was getting cumbersome, so I have refactored the predicate interface a little. Signed-off-by: Nic Cope <negz@rk0n.org>
...because I am pedantic. Signed-off-by: Nic Cope <negz@rk0n.org>
negz
added a commit
to negz/provider-gcp
that referenced
this pull request
Sep 15, 2019
crossplane/crossplane-runtime#24 Use the static binding compatible predicates introduced in the above PR. Note the updates to CRDs are due to recent documentation changes in core fields exposed by crossplane-runtime. Signed-off-by: Nic Cope <negz@rk0n.org>
negz
added a commit
to negz/provider-aws
that referenced
this pull request
Sep 15, 2019
crossplane/crossplane-runtime#24 Use the static provisioning compatible predicates introduced in the above PR. Note the updates to CRDs are due to recent documentation changes in core fields exposed by crossplane-runtime. Signed-off-by: Nic Cope <negz@rk0n.org>
negz
added a commit
to negz/provider-azure
that referenced
this pull request
Sep 15, 2019
crossplane/crossplane-runtime#24 Use the static provisioning compatible predicates introduced in the above PR. Note the updates to CRDs are due to recent documentation changes in core fields exposed by crossplane-runtime. Signed-off-by: Nic Cope <negz@rk0n.org>
wolffbe
pushed a commit
to wolffbe/provider-aws
that referenced
this pull request
Feb 12, 2021
crossplane/crossplane-runtime#24 Use the static provisioning compatible predicates introduced in the above PR. Note the updates to CRDs are due to recent documentation changes in core fields exposed by crossplane-runtime. Signed-off-by: Nic Cope <negz@rk0n.org>
namku
pushed a commit
to namku/provider-aws
that referenced
this pull request
Mar 9, 2021
crossplane/crossplane-runtime#24 Use the static provisioning compatible predicates introduced in the above PR. Note the updates to CRDs are due to recent documentation changes in core fields exposed by crossplane-runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes support for managed resources that do not reference a class. Controllers built against crossplane-runtime will currently panic if they encounter a managed resource without a class reference. Any dynamically provisioned managed resource will have a class reference, but this breaks the static provisioning workflow in which a managed resource is explicitly provisioned, then later claimed.
The PR also fixes watch predicates for the static binding flow We currently support dynamic provisioning in the resource claim reconciler by using a watch predicate that allows either managed resources that directly reference a non-portable resource class of a given kind, or resource claims that reference a non-portable resource class of a given kind indirectly via a portable resource class.
To support static provisioning (i.e. explicitly claiming an existing managed resource) we must also allow resource claims that explicitly reference a managed resource. Writing one predicate to do all of this was getting cumbersome, so I have refactored the predicate interface a little.
This PR will require additional PRs to update Crossplane core, and each stack.
Checklist
I have:
make reviewableto ensure this PR is ready for review.clusterrole.yamlto include any new types.