Upgrade to Go 1.18 #342
Merged
Upgrade to Go 1.18 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
3 tasks
muvaf
approved these changes
Jul 22, 2022
| @@ -38,15 +38,15 @@ func (e errNotFound) IsNotFound() bool { | |||
| // index was out of bounds in an array. | |||
| func IsNotFound(err error) bool { | |||
| cause := errors.Cause(err) | |||
| _, ok := cause.(interface { | |||
| _, ok := cause.(interface { //nolint: errorlint // Skip errorlint for interface type | |||
There was a problem hiding this comment.
Is there no way to use any here as well?
There was a problem hiding this comment.
any is only explicitly interoperable with interface{}, here it is an interface with function definitions
There was a problem hiding this comment.
Do you know if there is a plan to make it available for use in these cases as well, or are we stuck with interface{} for the foreseeable future?
| return pkg, err | ||
| } | ||
| if err == io.EOF { | ||
| if errors.Is(err, io.EOF) { |
There was a problem hiding this comment.
Just checked that errors.Is returns the same answer for == io.EOF by running the tests with coverage and seeing it go into this statement.
chlunde
added a commit
to chlunde/provider-aws
that referenced
this pull request
Aug 6, 2022
go mod tidy -compat=1.18 -go=1.18
cd build/
git fetch
git checkout origin/master
sed -i s,ubuntu-18.04,ubuntu-20.04,g .github/workflows/*
vim .github/workflows/ci.yml
inspired by crossplane/crossplane-runtime#342
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
2 tasks
chlunde
added a commit
to chlunde/provider-aws
that referenced
this pull request
Aug 25, 2022
go mod tidy -compat=1.18 -go=1.18
cd build/
git fetch
git checkout origin/master
sed -i s,ubuntu-18.04,ubuntu-20.04,g .github/workflows/*
vim .github/workflows/ci.yml
inspired by crossplane/crossplane-runtime#342
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
emelieakerstrom-sb1
pushed a commit
to sparebank1utvikling/provider-aws
that referenced
this pull request
Sep 28, 2022
go mod tidy -compat=1.18 -go=1.18
cd build/
git fetch
git checkout origin/master
sed -i s,ubuntu-18.04,ubuntu-20.04,g .github/workflows/*
vim .github/workflows/ci.yml
inspired by crossplane/crossplane-runtime#342
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
chlunde
added a commit
to chlunde/provider-sql
that referenced
this pull request
Nov 9, 2022
go mod tidy -compat=1.18 -go=1.18
cd build/
git fetch
git checkout origin/master
sed -i s,ubuntu-18.04,ubuntu-20.04,g .github/workflows/*
vim .github/workflows/ci.yml
inspired by crossplane/crossplane-runtime#342
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
chlunde
added a commit
to chlunde/provider-sql
that referenced
this pull request
Nov 11, 2022
go mod tidy -compat=1.18 -go=1.18
cd build/
git fetch
git checkout origin/master
sed -i s,ubuntu-18.04,ubuntu-20.04,g .github/workflows/*
vim .github/workflows/ci.yml
inspired by crossplane/crossplane-runtime#342
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Duologic
pushed a commit
to crossplane-contrib/provider-sql
that referenced
this pull request
Nov 18, 2022
* Upgrade to Go 1.18
go mod tidy -compat=1.18 -go=1.18
cd build/
git fetch
git checkout origin/master
sed -i s,ubuntu-18.04,ubuntu-20.04,g .github/workflows/*
vim .github/workflows/ci.yml
inspired by crossplane/crossplane-runtime#342
* gofmt -s -l -w ./*/
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya Sharma git@adi.run
Description of your changes
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested