removed kubebuilder validation

Signed-off-by: Neeraj Nagure <nagureneeraj@gmail.com>
crossplane · May 23, 2024 · 3e97742 · 3e97742
1 parent edb536d
commit 3e97742
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 36 deletions.
diff --git a/apis/apiextensions/v1/composition_revision_types.go b/apis/apiextensions/v1/composition_revision_types.go
@@ -38,8 +38,6 @@ const (
 type CompositionRevisionSpec struct {
 	// CompositeTypeRef specifies the type of composite resource that this
 	// composition is compatible with.
-	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:XValidation:rule="!has(oldSelf.value) || has(self.value)", message="Value is required once set"
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	CompositeTypeRef TypeReference `json:"compositeTypeRef"`
 
@@ -120,8 +118,6 @@ type CompositionRevisionSpec struct {
 	PublishConnectionDetailsWithStoreConfigRef *StoreConfigReference `json:"publishConnectionDetailsWithStoreConfigRef,omitempty"`
 
 	// Revision number. Newer revisions have larger numbers.
-	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:XValidation:rule="!has(oldSelf.value) || has(self.value)", message="Value is required once set"
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	Revision int64 `json:"revision"`
 }

diff --git a/apis/apiextensions/v1/composition_types.go b/apis/apiextensions/v1/composition_types.go
@@ -24,8 +24,6 @@ import (
 type CompositionSpec struct {
 	// CompositeTypeRef specifies the type of composite resource that this
 	// composition is compatible with.
-	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:XValidation:rule="!has(oldSelf.value) || has(self.value)", message="Value is required once set"
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	CompositeTypeRef TypeReference `json:"compositeTypeRef"`
 

diff --git a/apis/apiextensions/v1/xrd_types.go b/apis/apiextensions/v1/xrd_types.go
@@ -30,15 +30,11 @@ type CompositeResourceDefinitionSpec struct {
 	// Group specifies the API group of the defined composite resource.
 	// Composite resources are served under `/apis/<group>/...`. Must match the
 	// name of the XRD (in the form `<names.plural>.<group>`).
-	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:XValidation:rule="!has(oldSelf.value) || has(self.value)", message="Value is required once set"
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	Group string `json:"group"`
 
 	// Names specifies the resource and kind names of the defined composite
 	// resource.
-	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:XValidation:rule="!has(oldSelf.value) || has(self.value)", message="Value is required once set"
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	Names extv1.CustomResourceDefinitionNames `json:"names"`
 
@@ -51,8 +47,6 @@ type CompositeResourceDefinitionSpec struct {
 	// claim names to an existing CompositeResourceDefinition, but they cannot
 	// be changed or removed once they have been set.
 	// +optional
-	// +kubebuilder:validation:Optional
-	// +kubebuilder:validation:XValidation:rule="!has(oldSelf.value) || has(self.value)", message="Value is required once set"
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	ClaimNames *extv1.CustomResourceDefinitionNames `json:"claimNames,omitempty"`
 
@@ -76,8 +70,6 @@ type CompositeResourceDefinitionSpec struct {
 	// EnforcedCompositionRef refers to the Composition resource that will be used
 	// by all composite instances whose schema is defined by this definition.
 	// +optional
-	// +kubebuilder:validation:Optional
-	// +kubebuilder:validation:XValidation:rule="!has(oldSelf.value) || has(self.value)", message="Value is required once set"
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	EnforcedCompositionRef *CompositionReference `json:"enforcedCompositionRef,omitempty"`
 

diff --git a/apis/apiextensions/v1beta1/zz_generated.composition_revision_types.go b/apis/apiextensions/v1beta1/zz_generated.composition_revision_types.go
@@ -40,8 +40,6 @@ const (
 type CompositionRevisionSpec struct {
 	// CompositeTypeRef specifies the type of composite resource that this
 	// composition is compatible with.
-	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:XValidation:rule="!has(oldSelf.value) || has(self.value)", message="Value is required once set"
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	CompositeTypeRef TypeReference `json:"compositeTypeRef"`
 
@@ -122,8 +120,6 @@ type CompositionRevisionSpec struct {
 	PublishConnectionDetailsWithStoreConfigRef *StoreConfigReference `json:"publishConnectionDetailsWithStoreConfigRef,omitempty"`
 
 	// Revision number. Newer revisions have larger numbers.
-	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:XValidation:rule="!has(oldSelf.value) || has(self.value)", message="Value is required once set"
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	Revision int64 `json:"revision"`
 }

diff --git a/cluster/crds/apiextensions.crossplane.io_compositeresourcedefinitions.yaml b/cluster/crds/apiextensions.crossplane.io_compositeresourcedefinitions.yaml
@@ -114,8 +114,6 @@ spec:
                 - plural
                 type: object
                 x-kubernetes-validations:
-                - message: Value is required once set
-                  rule: '!has(oldSelf.value) || has(self.value)'
                 - message: Value is immutable
                   rule: self == oldSelf
               connectionSecretKeys:
@@ -277,8 +275,6 @@ spec:
                 - name
                 type: object
                 x-kubernetes-validations:
-                - message: Value is required once set
-                  rule: '!has(oldSelf.value) || has(self.value)'
                 - message: Value is immutable
                   rule: self == oldSelf
               group:
@@ -288,8 +284,6 @@ spec:
                   name of the XRD (in the form `<names.plural>.<group>`).
                 type: string
                 x-kubernetes-validations:
-                - message: Value is required once set
-                  rule: '!has(oldSelf.value) || has(self.value)'
                 - message: Value is immutable
                   rule: self == oldSelf
               metadata:
@@ -365,8 +359,6 @@ spec:
                 - plural
                 type: object
                 x-kubernetes-validations:
-                - message: Value is required once set
-                  rule: '!has(oldSelf.value) || has(self.value)'
                 - message: Value is immutable
                   rule: self == oldSelf
               versions:

diff --git a/cluster/crds/apiextensions.crossplane.io_compositionrevisions.yaml b/cluster/crds/apiextensions.crossplane.io_compositionrevisions.yaml
@@ -79,8 +79,6 @@ spec:
                 - kind
                 type: object
                 x-kubernetes-validations:
-                - message: Value is required once set
-                  rule: '!has(oldSelf.value) || has(self.value)'
                 - message: Value is immutable
                   rule: self == oldSelf
               environment:
@@ -1584,8 +1582,6 @@ spec:
                 format: int64
                 type: integer
                 x-kubernetes-validations:
-                - message: Value is required once set
-                  rule: '!has(oldSelf.value) || has(self.value)'
                 - message: Value is immutable
                   rule: self == oldSelf
               writeConnectionSecretsToNamespace:
@@ -1722,8 +1718,6 @@ spec:
                 - kind
                 type: object
                 x-kubernetes-validations:
-                - message: Value is required once set
-                  rule: '!has(oldSelf.value) || has(self.value)'
                 - message: Value is immutable
                   rule: self == oldSelf
               environment:
@@ -3227,8 +3221,6 @@ spec:
                 format: int64
                 type: integer
                 x-kubernetes-validations:
-                - message: Value is required once set
-                  rule: '!has(oldSelf.value) || has(self.value)'
                 - message: Value is immutable
                   rule: self == oldSelf
               writeConnectionSecretsToNamespace:

diff --git a/cluster/crds/apiextensions.crossplane.io_compositions.yaml b/cluster/crds/apiextensions.crossplane.io_compositions.yaml
@@ -74,8 +74,6 @@ spec:
                 - kind
                 type: object
                 x-kubernetes-validations:
-                - message: Value is required once set
-                  rule: '!has(oldSelf.value) || has(self.value)'
                 - message: Value is immutable
                   rule: self == oldSelf
               environment: