Merge pull request #5031 from phisco/dev/trace-xrc-secret

fix(cli): trace show xrc connection secret too

cmd/crank/beta/trace/internal/resource/client.go

@@ -133,7 +133,7 @@ func getResourceChildrenRefs(r *Resource, getConnectionSecrets bool) []v1.Object
 		return nil
 	}
 
-	if obj.GetNamespace() != "" {
+	if xrcNamespace := obj.GetNamespace(); xrcNamespace != "" {
 		// This is an XRC, get the XR ref, we leave the connection secret
 		// handling to the XR
 		xrc := claim.Unstructured{Unstructured: obj}
@@ -145,6 +145,18 @@ func getResourceChildrenRefs(r *Resource, getConnectionSecrets bool) []v1.Object
 				Namespace:  ref.Namespace,
 			})
 		}
+		if getConnectionSecrets {
+			xrcSecretRef := xrc.GetWriteConnectionSecretToReference()
+			if xrcSecretRef != nil {
+				ref := v1.ObjectReference{
+					APIVersion: "v1",
+					Kind:       "Secret",
+					Name:       xrcSecretRef.Name,
+					Namespace:  xrcNamespace,
+				}
+				refs = append(refs, ref)
+			}
+		}
 		return refs
 	}
 	// This could be an XR or an MR

cmd/crank/beta/trace/internal/resource/client_test.go

@@ -178,6 +178,12 @@ func TestGetResourceChildrenRefs(t *testing.T) {
 			},
 			want: want{
 				refs: []v1.ObjectReference{
+					{
+						APIVersion: "v1",
+						Kind:       "Secret",
+						Namespace:  "ns-1",
+						Name:       "secret-1",
+					},
 					{
 						APIVersion: "example.com/v1",
 						Kind:       "XR",