WIP: xrd/claim: event triggered composite update event

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
crossplane · Jul 11, 2023 · fd64e44 · fd64e44
1 parent bb58425
commit fd64e44
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/internal/controller/apiextensions/claim/reconciler.go b/internal/controller/apiextensions/claim/reconciler.go
@@ -520,6 +520,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (reco
 		return reconcile.Result{Requeue: true}, errors.Wrap(r.client.Status().Update(ctx, cm), errUpdateClaimStatus)
 	}
 
+	oldRV := cp.GetResourceVersion()
 	if err := r.client.Apply(ctx, cp); err != nil {
 		log.Debug(errApplyComposite, "error", err)
 		err = errors.Wrap(err, errApplyComposite)
@@ -528,8 +529,12 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (reco
 		return reconcile.Result{Requeue: true}, errors.Wrap(r.client.Status().Update(ctx, cm), errUpdateClaimStatus)
 	}
 
-	log.Debug("Successfully applied composite resource")
-	record.Event(cm, event.Normal(reasonCompositeConfigure, "Successfully applied composite resource"))
+	if oldRV != cp.GetResourceVersion() {
+		log.Debug("Successfully applied composite resource")
+		record.Event(cm, event.Normal(reasonCompositeConfigure, "Successfully applied composite resource"))
+	} else {
+		log.Debug("Skipped no-op composite resource apply")
+	}
 
 	if err := r.claim.Configure(ctx, cm, cp); err != nil {
 		log.Debug(errConfigureClaim, "error", err)