Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build automation to sync CRD definitions with changes to *types.go #28

Closed
jbw976 opened this issue Sep 18, 2018 · 1 comment
Closed

Comments

@jbw976
Copy link
Member

jbw976 commented Sep 18, 2018

When a change to a CRD spec is made in a *types.go file, it would be great to have that change also updated to the CRD definition in cluster/charts/conductor/crds. A common example is to add or rename a new field. Vanilla kubebuilder projects have this functionality and it looks to come from https://github.com/kubernetes-sigs/controller-tools/blob/master/pkg/crd/generator/generator.go.

We should incorporate this into our make build process as well.

@jbw976
Copy link
Member Author

jbw976 commented Jan 8, 2019

I believe this is done with the make manifests target: https://github.com/crossplaneio/crossplane/blob/master/Makefile#L63

@jbw976 jbw976 closed this as completed Jan 8, 2019
luebken pushed a commit to luebken/crossplane that referenced this issue Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant