Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove forked CreateOrUpdate once running controller-runtime >=0.2.0 #426

Closed
negz opened this issue May 1, 2019 · 2 comments
Closed

Remove forked CreateOrUpdate once running controller-runtime >=0.2.0 #426

negz opened this issue May 1, 2019 · 2 comments
Labels
techdebt Technical debt accumulated from prioritizing speed over quality

Comments

@negz
Copy link
Member

negz commented May 1, 2019

#420 (comment)

Per the above comment #420 introduces a fork of the CreateOrUpdate function from an unreleased version of https://github.com/kubernetes-sigs/controller-runtime. We should remove our fork and return to mainline once we bump controller-runtime to 0.2.0 or above.
@negz negz mentioned this issue May 1, 2019
Merged
9 tasks
@negz negz added the techdebt Technical debt accumulated from prioritizing speed over quality label Jun 3, 2019
@negz
Copy link
Member Author

negz commented Jun 4, 2019

Upgrading to controller-runtime 0.2.0 is tracked in #502.

@hasheddan hasheddan mentioned this issue Aug 21, 2019
Closed
@hasheddan
Copy link
Member

Closing in favor of crossplane/crossplane-runtime#2

luebken pushed a commit to luebken/crossplane that referenced this issue Aug 3, 2021
@hasheddan
Merge pull request crossplane#426 from hasheddan/panic-s3-lifecycle
a792e81 
Do not panic on missing date in bucket lifecycleConfig
plumbis pushed a commit to plumbis/crossplane that referenced this issue Oct 31, 2023
@mamachanko
Document patching a composed resource from itself (crossplane#426)
857152d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
techdebt Technical debt accumulated from prioritizing speed over quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@negz @hasheddan