Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.14/v1.15 - cannot change the kind or group of a composed resource #5473

Closed
haarchri opened this issue Mar 13, 2024 · 0 comments · Fixed by #5474
Closed

v1.14/v1.15 - cannot change the kind or group of a composed resource #5473

haarchri opened this issue Mar 13, 2024 · 0 comments · Fixed by #5474

Comments

@haarchri
Copy link
Contributor

haarchri commented Mar 13, 2024

What happened?

We're working on moving our resources from the community AWS provider (https://github.com/crossplane-contrib/provider-aws) to the official Upbound AWS provider (https://github.com/upbound/provider-aws).

Here's a brief overview of the steps involved:

  1. Add crossplane.io/paused annotation and deletionPolicy: Orphan on all community managed resources
  2. Shift all managed resources to the official provider.
  3. In the Git repository, update the composition but keep the order and spec.resources[].name unchanged.
  4. Apply the updated composition.
  5. The composition will detect all new resources and update resourceRefs[].apiVersion and resourceRefs[].Kind in the XR, while the resource names remain the same.
  6. Remove all community managed resources from the community AWS provider.

This process worked with Crossplane version v1.13.x but encountered issues starting with versions v1.14.x/v1.15.x. The error message encountered is:

cannot compose resources: cannot parse base template of composed resource 'iam': cannot change the kind or group of a composed resource from iam.aws.crossplane.io/v1beta1, Kind=Role to iam.aws.upbound.io/v1beta1, Kind=Role (possible composed resource template mismatch)

The change in behavior with Crossplane versions v1.14.x and v1.15.x raises questions, especially since migrating to the official provider is a common use case.

change of the behavior implemented with: #4500
recent change for version updates: #5369
discussion between @phisco and @turkenh #5369 (comment)

How can we reproduce it?

https://github.com/haarchri/xp-issue-5473

What environment did it happen in?

Crossplane version: v1.14.6-up.1, v1.15.0-up.1

@haarchri haarchri added the bug Something isn't working label Mar 13, 2024
turkenh added a commit to turkenh/crossplane that referenced this issue Mar 13, 2024
Fixes crossplane#5473

Signed-off-by: Hasan Turken <turkenh@gmail.com>
@jbw976 jbw976 added this to the v1.16 milestone Mar 13, 2024
github-actions bot pushed a commit that referenced this issue Mar 14, 2024
Fixes #5473

Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit d347ff3)
github-actions bot pushed a commit that referenced this issue Mar 14, 2024
Fixes #5473

Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit d347ff3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants