We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make generate
Running make generate more than once results in the following error:
20:50:21 [ .. ] patching generated CRDs mkdir: /Users/jared/dev/go/src/github.com/crossplane/crossplane/.work/patch: File exists make[1]: *** [crds.patch] Error 1 make: *** [generate] Error 2
This also leaves a side effect of the cluster/crds/pkg.crossplane.io_deploymentruntimeconfigs.yaml file being modified with the following diff:
cluster/crds/pkg.crossplane.io_deploymentruntimeconfigs.yaml
diff --git a/cluster/crds/pkg.crossplane.io_deploymentruntimeconfigs.yaml b/cluster/crds/pkg.crossplane.io_deploymentruntimeconfigs.yaml index 35a599ab7..f876d0e55 100644 --- a/cluster/crds/pkg.crossplane.io_deploymentruntimeconfigs.yaml +++ b/cluster/crds/pkg.crossplane.io_deploymentruntimeconfigs.yaml @@ -4211,8 +4211,6 @@ spec: ip: description: IP address of the host file entry. type: string - required: - - ip type: object type: array x-kubernetes-list-map-keys: @@ -4267,8 +4265,6 @@ spec: More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names TODO: Add other useful fields. apiVersion, kind, uid? type: string - required: - - name type: object x-kubernetes-map-type: atomic type: array
This looks related to recently added build logic in 355ba7a
Run make generate two times in a row.
Workaround: rm -fr .work/patch and then run make generate again.
rm -fr .work/patch
Crossplane version: v1.17.0-rc.0.120.g914b83a3c, corresponding to 914b83a
v1.17.0-rc.0.120.g914b83a3c
The text was updated successfully, but these errors were encountered:
jbw976
Successfully merging a pull request may close this issue.
What happened?
Running
make generate
more than once results in the following error:This also leaves a side effect of the
cluster/crds/pkg.crossplane.io_deploymentruntimeconfigs.yaml
file being modified with the following diff:This looks related to recently added build logic in 355ba7a
How can we reproduce it?
Run
make generate
two times in a row.Workaround:
rm -fr .work/patch
and then runmake generate
again.What environment did it happen in?
Crossplane version:
v1.17.0-rc.0.120.g914b83a3c
, corresponding to 914b83aThe text was updated successfully, but these errors were encountered: