Update Helm 3 installation instructions for pre-1.15 clusters #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hasheddan
approved these changes
Feb 13, 2020
jbw976
reviewed
Feb 14, 2020
cluster/charts/crossplane/README.md
Outdated
| ```console | ||
| kubectl create namespace crossplane-system | ||
| helm repo add crossplane-alpha https://charts.crossplane.io/alpha | ||
|
|
||
| # post-1.15 cluster |
There was a problem hiding this comment.
should this be 1.15 and after, or 1.15+ cluster? the two headers of pre 1.15 and post 1.15 aren't clear on which bucket 1.15 falls into
There was a problem hiding this comment.
Just updated to make it more clear
…clusters Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
jbw976
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The details are in #1170 . Long story short, Crossplane could not be installed to pre-1.15 clusters if CRDs had to be validated, which was the case in Helm 3 until 3.1 release which has a flag
--disable-openapi-validation.Fixes #1170
How has this code been tested?
I've tested this in a Kubernetes 1.13.11 cluster which is default version in GKE.
Checklist
I have:
make reviewableto ensure this PR is ready for review.appropriate.
For more about what we believe makes a pull request complete, see our
definition of done.