NoSQLDB spec. #1356
Merged
NoSQLDB spec. #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
reviewed
Mar 20, 2020
There was a problem hiding this comment.
Thanks @artursouza! One very small nitpick, otherwise LGTM!
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
|
Thanks @artursouza! We're actually hoping this fixed set of resource claim schema definitions will go away once #1163 lands, but until that time this seems appropriate. |
negz
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Souza artursouza.ms@outlook.com
Description of your changes
NoSQLDB spec: first step to get MongoDB support via CosmosDB.
Partially addresses #280
How has this code been tested?
Checklist
I have:
make reviewableto ensure this PR is ready for review.appropriate.
For more about what we believe makes a pull request complete, see our
definition of done.