Correct Postgresql engine version #1580
Conversation
Followed provision infrasture to provision an RDSInstance CRD, it failed with the issue connect failed: cannot get provider secret: Secret "alibaba-creds" not found. By creating the secret in namespace `crossplane-system` will fix the issue Signed-off-by: zzxwill <zzxwill@gmail.com>
allowed engine version should among 9.4/10.0/11.0/12.0 Signed-off-by: zzxwill <zzxwill@gmail.com>
|
Please hold on, this modification might affect the engine version for AWS/GCP/Azure, sorry. Let me think it over. |
cluster/charts/crossplane-types/crds/database.crossplane.io_postgresqlinstances.yaml
Outdated
Show resolved
Hide resolved
|
As @hasheddan pointed out, claims are to be deprecated. But we're still supporting them. I think we can get rid of this whole list altogether. If an unsupported version is used, provider will return an error anyway. @zzxwill removing the line here and running |
Got it. I will push another commit. Thanks. |
…-version Merge upstream/master to fix branch Signed-off-by: zzxwill <zzxwill@gmail.com>
As CRD manifest is generated by go module, so revert previous change on the manifest and remove engine version constrains. Signed-off-by: zzxwill <zzxwill@gmail.com>
| - "10.0" | ||
| - "11.0" | ||
| - "12.0" | ||
| - "9.6" |
There was a problem hiding this comment.
Did you run make reviewable after removing the validation line? I'd expect the enum array here to go away automatically since CRDs are deleted and regenerated via make reviewable
There was a problem hiding this comment.
No. But I did just now following with another commit. Thank you, now I learnt the mechanism.
Signed-off-by: zzxwill <zzxwill@gmail.com>
Signed-off-by: zzxwill <zzxwill@gmail.com>
Description of your changes
Fix issue crossplane-contrib/provider-alibaba#23
How has this code been tested?
Checklist
I have:
make reviewableto ensure this PR is ready for review.appropriate.
For more about what we believe makes a pull request complete, see our
definition of done.