Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate claims #1600

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Deprecate claims #1600

merged 1 commit into from
Jun 18, 2020

Conversation

hasheddan
Copy link
Member

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Description of your changes

Fixes #1479

This marks all claim types as deprecated in favor of moving to
composition to define infrastructure.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

This marks all claim types as deprecated in favor of moving to
composition to define infrastructure.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan requested review from kasey, negz and muvaf June 18, 2020 21:15
@negz negz merged commit 323908c into crossplane:master Jun 18, 2020
@negz
Copy link
Member

negz commented Jun 18, 2020

Thanks @hasheddan!

@muvaf
Copy link
Member

muvaf commented Jun 19, 2020

I wish there was a way to make kubectl commands that are run against deprecated CRDs to print the deprecation notice. kubectl create -> warning: deprecated but i will create it

@muvaf
Copy link
Member

muvaf commented Jun 19, 2020

Created kubernetes/kubernetes#92290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate resource claims and classes
3 participants