Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default and enforced composition ref features to documentation #1607

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

muvaf
Copy link
Member

@muvaf muvaf commented Jun 22, 2020

Description of your changes

These features are implemented but not documented.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

None.

Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think DCO is needed here

Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
@hasheddan
Copy link
Member

I see DCO added now :) Feel free to merge at will 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants