Remove superseded features ahead of v0.13 release #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
requested review from
prasek,
jbw976,
muvaf,
hasheddan and
ryanzhang-oss
hasheddan
reviewed
Sep 21, 2020
2 tasks
muvaf
reviewed
Sep 21, 2020
|
I’d like to merge it soon if others feel comfortable. It’s almost entirely a red diff - there are some things (examples, installing providers via the Helm chart) that I’d like us to handle as follow-on work. |
This controller automatically generates KubernetesTargets for each KuberntesCluster claim. We're marking KubernetesTarget deprecated in v0.13 along with KubernetesApplications (but not removing them). The KubernetesCluster claim is being removed in v0.13, so this controller must go. Users will still be able to manually create KubernetesTargets until they are removed in a future release. Signed-off-by: Nic Cope <negz@rk0n.org>
Resource claims were deprecated in v0.12 and slated for removal in v0.13. Signed-off-by: Nic Cope <negz@rk0n.org>
Resource claims are slated for removal in v0.13. Signed-off-by: Nic Cope <negz@rk0n.org>
This API group has not existed for some time. Signed-off-by: Nic Cope <negz@rk0n.org>
We've taken our learnings from the original Crossplane package manager, and used them to build a new one. The original package manager grew from the 'stack manager'. It most recently operated on types in the packages.crossplane.io API group - e.g. ClusterPackageInstall. This package manager was designed to solve problems that Crossplane now deems to be outside its scope - i.e. installing user-facing application logic, and arbitrary Kubernetes controllers. The new package manager operates on types in the pkg.crossplane.io API group. It is designed specifically to install providers and configuration for Crossplane, not arbitrary controllers or applications. The new package manager is designed to support updating packages (e.g. to install a new version of a provider) and to automatically resolve package dependencies. (The latter is coming soon.) The removal of resource claims in v0.13 mean the majority of v0.12 (and earlier) era packages will not function with v0.13 due to the lack of claim and class CRDs: * Provider packages will panic without claim CRDs installed. * Many app packages (e.g. Wordpress) will not function without claim CRDs Upgrading to v0.13 without also migrating to v0.13 era providers (and thus to the v0.13 package manager) may be possible with manual intervention, but is likely to be equally as or more complicated than upgrading to v0.13 and to the new package manager. Signed-off-by: Nic Cope <negz@rk0n.org>
In v0.13 these controllers will be installed and run by oam-kubernetes-runtime, which will be installed as a subchart of Crossplane's Helm chart. Signed-off-by: Nic Cope <negz@rk0n.org>
Signed-off-by: Nic Cope <negz@rk0n.org>
Rather than the (now removed) package manager. Signed-off-by: Nic Cope <negz@rk0n.org>
These are almost entirely stale. I've moved anything referenced from our docs into the docs/snippets directory. We may want to follow up by pointing to the examples in each provider's repo. Signed-off-by: Nic Cope <negz@rk0n.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1702
Updates #1670
This PR removes:
KubernetesTargetfor eachKubernetesClusterclaim.The removal of the original package manager was not originally planned for v0.13, but keeping it around makes little sense given the removal of resource claims. See the relevant commit message for more context.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I've built and deployed this branch, along with crossplane-contrib/provider-gcp#254 (which is built against this branch and crossplane/crossplane-runtime#201). All seems to be working as expected when I run through the GCP composition examples.