Cleanup Composition 'Type' discriminator fields #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
commented
Feb 12, 2021
benagricola
reviewed
Feb 12, 2021
2 tasks
* Aligns on 'FooType' for all 'type' field... types. * Replicates some changes from the v1 API that were missed in the v1beta1 API. Signed-off-by: Nic Cope <negz@rk0n.org>
Just to keep with the 'From' theme of the other types. Signed-off-by: Nic Cope <negz@rk0n.org>
Without this Crossplane assumes they're FromConnectionSecretKey type connection details. Signed-off-by: Nic Cope <negz@rk0n.org>
This maintains backward compatibiltiy with the behaviour we had before we let API consumers explicitly declare their intended connection detail type. Signed-off-by: Nic Cope <negz@rk0n.org>
Signed-off-by: Nic Cope <negz@rk0n.org>
hasheddan
approved these changes
Feb 13, 2021
| @@ -346,6 +347,7 @@ const ( | |||
| type Transform struct { | |||
|
|
|||
| // Type of the transform to be run. | |||
| // +kubebuilder:validation:Enum=map;math;string;convert | |||
There was a problem hiding this comment.
Just noting here while this is technically restricting the allowed value for this field at the API server, we are currently erroring out before creating any composed managed resources, so this change should not break any current consumers of this functionality 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR:
FooTypetypes are namedFooType, notTypeFoo.ConnectionDetailTypeto "ValueFrom".I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I haven't - they're all pretty trivial.