[release-1.2] Cherry pick ControllerConfig and Lock fixes #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates dependency resolver controller to remove finalizer on lock and exit early without requeue if the lock package list is empty. This allows for cleanup of the lock when uninstalling Crossplane after all packages have already been uninstalled. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit c60b6de)
The dependency resolver controller should only attempt resolution when the lock has packages entries. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit d93c096)
Removes the step from uninstalling Crossplane documentation where finalizers must be removed from the Lock before CRDs are deleted. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit 8e91cb4)
Updates revision controllers to create the lock if it does not exist when resolving dependencies. If a package revision is inactive it will not create the lock as its only purpose would be to remove itself from it. If a package opts out of dependency management it will not create the lock as it does not attempt to consider dependencies. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit 0f5d56d)
In scenarios where the lock does not exist the revision should attempt to create it unless it is inactive. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit fa8d6f3)
Currently the ControllerConfig API supports setting the imagePullPolicy for the Controller Deployment, but it is not being honored when constructing the Deployment. This updates to honor it. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit ac693fe)
negz
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Cherry picks commits from #2340 #2331 #2321. Does not include #2328 as, though it was documented in the design doc, I am still considering it a feature.
I have:
make reviewable testto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Each of these was tested in their respective PRs and on
master, and overall are fairly non-controversial bug fixes.