Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete one pager host aware stack manager #2402

Merged

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Jun 28, 2021

Description of your changes

This PR deletes the one-pager doc for host aware stack manager which is a feature that was removed from Crossplane a long time ago.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

N/A

@turkenh turkenh requested a review from hasheddan June 28, 2021 11:47
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turkenh I think our latest thinking on design docs was to move ones that are no longer accurate or maintained to a deprecated/ subdirectory and marking as deprecated in the Status. Would you be willing to get that started with this doc?

Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh turkenh force-pushed the remove-design-host-aware-stack-manager branch from ae2370b to f086fa7 Compare June 28, 2021 11:54
@turkenh
Copy link
Member Author

turkenh commented Jun 28, 2021

@turkenh I think our latest thinking on design docs was to move ones that are no longer accurate or maintained to a deprecated/ subdirectory and marking as deprecated in the Status. Would you be willing to get that started with this doc?

@hasheddan thanks for the pointer, should be done!

@turkenh turkenh requested a review from hasheddan June 28, 2021 11:55
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @turkenh!

@hasheddan hasheddan merged commit 8e5684f into crossplane:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants