Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBM Power Linux Platform (ppc64le) support #2431

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Add IBM Power Linux Platform (ppc64le) support #2431

merged 1 commit into from
Jul 12, 2021

Conversation

amitsadaphule
Copy link
Contributor

Description of your changes

Fixes #2424

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

I used the following steps to validate the changes on a RH8.3 ppc64le VM with docker 19.03.8:

docker run --rm --privileged tonistiigi/binfmt:latest --install all
wget https://github.com/docker/buildx/releases/download/v0.4.2/buildx-v0.4.2.linux-ppc64le
mv buildx-v0.4.2.linux-ppc64le docker-buildx
chmod a+x docker-buildx
mkdir ~/.docker/cli-plugins; mv docker-buildx ~/.docker/cli-plugins/
docker buildx create --name builder-44d7402c-521e-43d5-aa50-064d1fe5a99a --driver docker-container --buildkitd-flags '--allow-insecure-entitlement security.insecure --allow-insecure-entitlement network.host' --use
docker buildx inspect --bootstrap --builder builder-44d7402c-521e-43d5-aa50-064d1fe5a99a
docker buildx install

yum install -y make git wget gcc perl-Digest-SHA

# Download and install go
wget https://golang.org/dl/go1.14.13.linux-ppc64le.tar.gz
tar -xzf go1.14.13.linux-ppc64le.tar.gz
rm -rf go1.14.13.linux-ppc64le.tar.gz
export GOPATH=`pwd`/gopath
export PATH=`pwd`/go/bin:$GOPATH/bin:$PATH

mkdir -p $GOPATH/src/github.com/crossplane
cd $GOPATH/src/github.com/crossplane
git clone https://github.com/crossplane/crossplane.git
cd crossplane/

### APPLY THE PATCH

make submodules
make vendor vendor.check
make BUILD_ARGS="--load" -j2 build.all
make test
make e2e

And then confirmed that the crossplane pods come up in minikube cluster as:

docker tag build-a5425108/crossplane-ppc64le:latest crossplane/crossplane:v1.4.0-rc.0.42.gaa7c2807.dirty
helm install crossplane --namespace crossplane-system `pwd`/cluster/charts/crossplane/ --set image.pullPolicy=Never,imagePullSecrets=''

Resolves #2424

Signed-off-by: Amit Sadaphule <amits2@us.ibm.com>
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM -- I don't have a great way of testing this at the moment, but it should be non-disruptive to other builds, so I suggest moving ahead with adding support here and testing the produced artifacts 👍🏻 Thanks for working on this @amitsadaphule!

@hasheddan hasheddan merged commit b1a6b20 into crossplane:master Jul 12, 2021
@negz negz added this to In progress in v1.4 via automation Aug 17, 2021
@negz negz moved this from In progress to Done in v1.4 Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1.4
Done
Development

Successfully merging this pull request may close these issues.

Enhancement Request: add IBM Power Linux Platform (ppc64le) support
2 participants