Mark many design documents defunct #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These documents are just that. I'm also moving them into a directory to more clearly distinguish which design docs are still relevant. Signed-off-by: Nic Cope <negz@rk0n.org>
Upbound Cloud actually still respects this spec, but the design is Upbound specific and thus belongs under the github.com/upbound org - perhaps in the Universal Crossplane repository. Signed-off-by: Nic Cope <negz@rk0n.org>
We have a few design documents that are still mostly accurate and interesting when it comes to describing problems we've wanted to solve, but that either mention defunct concepts (e.g. resource classes) or go into detail about the initial rather than the current technical implementation of a problem (e.g. the code examples in the cross resource references document). Signed-off-by: Nic Cope <negz@rk0n.org>
Signed-off-by: Nic Cope <negz@rk0n.org>
I broke a bunch of these in a previous commit by moving design docs into the defunct directory. Signed-off-by: Nic Cope <negz@rk0n.org>
hasheddan
approved these changes
Jul 13, 2021
Ah good catch - I pushed a commit to fix those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1711
This PR moves many documents into the
design/defunctdirectory and updates their status to "Defunct". It also removes two Upbound Cloud specific designs that belong in an Upbound repository. Finally, it explains how we're currently approaching design documents (i.e. that we don't always update them to represent the latest iteration of an implementation).I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
N/A.