Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page documenting Crossplane terminology #2443

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

negz
Copy link
Member

@negz negz commented Jul 21, 2021

Description of your changes

We don't currently have a single place to find details about common Crossplane concepts. I've added this under 'concepts' rather than 'reference' in the hope it might be more discoverable there, though I could go either way.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

I've asked a few Upbounders to review this, and would like to have the community take a look before merging.

Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but none of them blocking, thanks for adding this @negz! I think this will be very useful for folks :)

docs/concepts/terminology.md Show resolved Hide resolved
docs/concepts/terminology.md Show resolved Hide resolved
docs/concepts/terminology.md Outdated Show resolved Hide resolved
docs/concepts/terminology.md Show resolved Hide resolved
Copy link
Member

@thephred thephred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit picks and suggestions. This looks great @negz!

docs/concepts/terminology.md Outdated Show resolved Hide resolved
docs/concepts/terminology.md Show resolved Hide resolved
docs/concepts/terminology.md Show resolved Hide resolved
docs/concepts/terminology.md Show resolved Hide resolved
docs/concepts/terminology.md Outdated Show resolved Hide resolved
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thank you @negz !

We don't currently have a single place to find details about common Crossplane
concepts. I've added this under 'concepts' rather than 'reference' in the hope
it might be more discoverable there, though I could go either way.

Signed-off-by: Nic Cope <negz@rk0n.org>
@github-actions
Copy link

Successfully created backport PR #2446 for release-1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants