Output darwin_amd64 for both x86_64 and amd64 in install.sh #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Thornton <taylor@upbound.io>
|
Thank you, just worked around this myself with |
3 tasks
hasheddan
approved these changes
Aug 4, 2021
|
Wonder if in the future leveraging GH actions runs-on systems can help with that testing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
A recent change #2453 accidentally removed support for darwin_x86_64. This change follows the linux conditional approach and uses darwin_amd64 if either x86_64 or amd64 is seen.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Ran changes for darwin_arm64 locally. Unfortunately I don't have a way to test darwin_amd64 nor darwin_x86_64.