Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build submodule with optional docs publishing #2513

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

hasheddan
Copy link
Member

Description of your changes

Updates the build submodule to include optionally publishing docs. When
a branch is no longer supported, the Makefile should be updated to
DOCS_VERSION_ACTIVE=false and it will be removed when publishing to the
docs repo.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

xref crossplane/docs#107

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

See upbound/build#166

Updates the build submodule to include optionally publishing docs. When
a branch is no longer supported, the Makefile should be updated to
DOCS_VERSION_ACTIVE=false and it will be removed when publishing to the
docs repo.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan merged commit 45a231c into crossplane:master Aug 23, 2021
@github-actions
Copy link

Backport failed for release-1.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.2
git worktree add -d .worktree/backport-2513-to-release-1.2 origin/release-1.2
cd .worktree/backport-2513-to-release-1.2
git checkout -b backport-2513-to-release-1.2
ancref=$(git merge-base 8b51c9d93ee09e8af214625d41df61c7d700fa4e 389b813867db730a4d07bc70a863b4806a7914c6)
git cherry-pick -x $ancref..389b813867db730a4d07bc70a863b4806a7914c6

@github-actions
Copy link

Backport failed for release-1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.1
git worktree add -d .worktree/backport-2513-to-release-1.1 origin/release-1.1
cd .worktree/backport-2513-to-release-1.1
git checkout -b backport-2513-to-release-1.1
ancref=$(git merge-base 8b51c9d93ee09e8af214625d41df61c7d700fa4e 389b813867db730a4d07bc70a863b4806a7914c6)
git cherry-pick -x $ancref..389b813867db730a4d07bc70a863b4806a7914c6

@github-actions
Copy link

Backport failed for release-1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.3
git worktree add -d .worktree/backport-2513-to-release-1.3 origin/release-1.3
cd .worktree/backport-2513-to-release-1.3
git checkout -b backport-2513-to-release-1.3
ancref=$(git merge-base 8b51c9d93ee09e8af214625d41df61c7d700fa4e 389b813867db730a4d07bc70a863b4806a7914c6)
git cherry-pick -x $ancref..389b813867db730a4d07bc70a863b4806a7914c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants