-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Composition] Adding string transform ToUpper/ToLower #2592
[Composition] Adding string transform ToUpper/ToLower #2592
Conversation
6652bab
to
36e95c3
Compare
ea9a973
to
496e309
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, but in general this looks great. Thank you!
4886b43
to
c406d0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits and a question that would be nice to fix before we merge, but mostly this looks great. Thanks @mcbenjemaa!
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
…tringTransform to v1beta1 Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
ce40ba3
to
172e07a
Compare
172e07a
to
d5f76c3
Compare
Thank you for working on this @mcbenjemaa! One final thing - could you add a section for this new transform to the docs? Apologies that I didn't think to mention this earlier. |
Code looks good but I'd like to wait for docs too.
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
Description of your changes
Adding 2 fields to the
StringTransform
, in order to make it possible to add extra functionally of the string transformation.In our case we need to add a convert ToUpper/ToLower.
string.type
field is required and so, every time must be set! (breaking change!!) any thoughts ?string.fmt
used to format string as usual.string.convert
accepts 2 valuesToUpper
,ToLower
, will convert the string according to it's value.Fixes #2579
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.cc @negz
/label "backport release-1.5"
How has this code been tested
Tested locally using kind cluster.