Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated transform types example #2626

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

Feggah
Copy link
Member

@Feggah Feggah commented Oct 14, 2021

Description of your changes

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

N/A

Signed-off-by: Feggah <gabidferreira9@gmail.com>
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Feggah! I have added backport labels for all active branches as this functionality has operated as indicated in your changeset here since #1994 👍🏻

@hasheddan hasheddan merged commit a6318dd into crossplane:master Oct 14, 2021
@github-actions
Copy link

Backport failed for release-1.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.2
git worktree add -d .worktree/backport-2626-to-release-1.2 origin/release-1.2
cd .worktree/backport-2626-to-release-1.2
git checkout -b backport-2626-to-release-1.2
ancref=$(git merge-base fc41839024582bdf0b6075e0f737524511bc1afe 3f2e6bb9b687e20400b863cd41c0da7639ed86a2)
git cherry-pick -x $ancref..3f2e6bb9b687e20400b863cd41c0da7639ed86a2

@github-actions
Copy link

Backport failed for release-1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.3
git worktree add -d .worktree/backport-2626-to-release-1.3 origin/release-1.3
cd .worktree/backport-2626-to-release-1.3
git checkout -b backport-2626-to-release-1.3
ancref=$(git merge-base fc41839024582bdf0b6075e0f737524511bc1afe 3f2e6bb9b687e20400b863cd41c0da7639ed86a2)
git cherry-pick -x $ancref..3f2e6bb9b687e20400b863cd41c0da7639ed86a2

@github-actions
Copy link

Successfully created backport PR #2627 for release-1.4.

@Feggah Feggah mentioned this pull request Oct 14, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation about convert transform type outdated
2 participants