Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compositionrevision): Add missing JSON marshaller to CompositionRevision's MapTransform #2856

Merged

Conversation

MisterMX
Copy link
Contributor

Description of your changes

This adds the missing JSON marshalling methods to CompositionRevision's own MapTransform type.

Fixes #2836

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Manually

…evision's MapTransform

Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
(external expert on behalf of DB Netz AG)
@MisterMX MisterMX force-pushed the fix-compositionrevision-maptransform branch from 89ff7a8 to f4d72c6 Compare January 24, 2022 15:54
@negz negz self-requested a review February 10, 2022 18:41
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @MisterMX! Sorry I somehow missed the PR for so long.

@negz
Copy link
Member

negz commented Feb 10, 2022

I'd like to backport this, but GitHub isn't currently letting me add labels. 🤔 I'm going to wait a while and see if that resolves.

@github-actions
Copy link

Successfully created backport PR #2891 for release-1.4.

@github-actions
Copy link

Successfully created backport PR #2892 for release-1.5.

@github-actions
Copy link

Successfully created backport PR #2893 for release-1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompositionRevision does not work when Composition has a Map transform
2 participants