feat(claim): Add SYCNED condition to XRs and XRCs #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
force-pushed
the
sync-condition
branch
from
273a722
to
4a46870
Compare
negz
reviewed
Mar 22, 2022
| } | ||
|
|
||
| return res, errors.Wrap(r.client.Status().Update(ctx, cm), errUpdateClaimStatus) | ||
| } |
There was a problem hiding this comment.
I'd prefer to update the reconciler to set ReconcileError as part of the existing SetConditions calls, rather than moving the bulk of the logic into a wrapped reconcile method. The former approach is more in line with how we approach this in the managed reconciler, for example:
There was a problem hiding this comment.
I rewrote the changes so the status updates follow the old pattern, although I don't think its the best decision and creates a lot of redundant code.
@negz can you have another look at it?
Fixes crossplane#2850 * Add `Synced` condition that can be used to track reconcile errors (similar to managed resources in providers) * Add an additional printer column to XR CRDs that references the `Synced` condition Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com> (external expert on behalf of DB Netz AG)
6 tasks
MisterMX
requested review from
a team,
nullable-eth and
bobh66
and removed request for
a team
negz
approved these changes
Sep 12, 2022
|
Apparently I can't merge this PR - I think because it hasn't been approved by any CODEOWNERS (which would in this case be a member of the reviewers group or muvaf). |
bobh66
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #2850
Syncedcondition that can be used to track reconcile errors(similar to managed resources in providers)
SyncedconditionI have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually and unit tests