Update xpkg spec with webhook configurations in providers #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the xpkg spec to include AdmissionWebhookConfiguration and MutatingWebhookConfiguration as valid types in a Provider package. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
muvaf
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Thanks @hasheddan ! Do you want to version the spec at one point?
hasheddan
commented
Mar 22, 2022
There was a problem hiding this comment.
Do you want to version the spec at one point?
@muvaf I think that could be a good idea -- although since it is included in the documentation, the versioning is somewhat implied by the version of the docs you select. I think it could be helpful to have a Added in vX.Y.Z note for features we add in the future though 👍🏻
|
Successfully created backport PR #2997 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates the xpkg spec to include AdmissionWebhookConfiguration and
MutatingWebhookConfiguration as valid types in a Provider package.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Fixes #2975
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
n/a -- documentation only