Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add argo cd guide #3041

Merged
merged 13 commits into from
Sep 2, 2022
Merged

add argo cd guide #3041

merged 13 commits into from
Sep 2, 2022

Conversation

natereid72
Copy link
Contributor

@natereid72 natereid72 commented Apr 12, 2022 •
edited by jbw976

Description of your changes

Adding guide to cover configuring Argo CD with Crossplane

This documentation should fix #2121, in the sense that the community will have the resource necessary to configure Argo to play well with Crossplane

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

No testing. Doc update.

@natereid72 natereid72 marked this pull request as draft April 12, 2022 19:26
@natereid72 natereid72 marked this pull request as ready for review April 12, 2022 19:27
@natereid72
Copy link
Contributor Author

@hasheddan This was a request from @luebken. I couldn't label the backport. but hope the rest is good.

@natereid72
Copy link
Contributor Author

@jbw976

negz
negz reviewed Jun 14, 2022
View reviewed changes
docs/guides/argo-cd-crossplane.md Outdated Show resolved Hide resolved
docs/guides/vault-as-secret-store.md Outdated Show resolved Hide resolved
@natereid72 natereid72 requested review from a team as code owners August 22, 2022 18:12
ytsarev
ytsarev requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natereid72 please consider review suggestions

docs/guides/argo-cd-crossplane.md Outdated Show resolved Hide resolved
docs/guides/argo-cd-crossplane.md Outdated Show resolved Hide resolved
docs/guides/argo-cd-crossplane.md Show resolved Hide resolved
docs/guides/argo-cd-crossplane.md Outdated Show resolved Hide resolved
docs/guides/argo-cd-crossplane.md Outdated Show resolved Hide resolved
docs/guides/argo-cd-crossplane.md Outdated Show resolved Hide resolved
docs/guides/argo-cd-crossplane.md Outdated Show resolved Hide resolved
docs/guides/vault-as-secret-store.md Outdated Show resolved Hide resolved
docs/guides/vault-as-secret-store.md Outdated Show resolved Hide resolved
@jbw976 jbw976 mentioned this pull request Aug 25, 2022
Closed
ytsarev
ytsarev approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes, lgtm

@ytsarev
Copy link
Member

ytsarev commented Aug 25, 2022

@natereid72 argh, looks like DCO is broken after GitHub suggestion-based commit. You'll need to add 'Signed-off-by' to them

@negz
Copy link
Member

negz commented Aug 25, 2022

DCO is broken after GitHub suggestion-based commit. You'll need to add 'Signed-off-by' to them

I recommend squashing these all into one commit, and signing that one.

natereid72 and others added 13 commits September 2, 2022 01:02
@natereid72
add argoc cd guide
25f73c1 
Signed-off-by: natereid72 <natereid@protonmail.com>
@natereid72
switch to helm values file
d11c7f9
@natereid72
Update argo-cd-crossplane.md
f269725
@natereid72
Update argo-cd-crossplane.md
9086aea
@natereid72
Update argo-cd-crossplane.md
d4c7615
@natereid72 @ytsarev
Update docs/guides/argo-cd-crossplane.md
1648480 
Co-authored-by: Yury Tsarev <yury@upbound.io>
@natereid72 @ytsarev
Update docs/guides/argo-cd-crossplane.md
1eeb646 
Co-authored-by: Yury Tsarev <yury@upbound.io>
@natereid72 @ytsarev
Update docs/guides/argo-cd-crossplane.md
ae8048a 
Co-authored-by: Yury Tsarev <yury@upbound.io>
@natereid72 @ytsarev
Update docs/guides/argo-cd-crossplane.md
790ec50 
Co-authored-by: Yury Tsarev <yury@upbound.io>
@natereid72 @ytsarev
Update docs/guides/argo-cd-crossplane.md
0a2d888 
Co-authored-by: Yury Tsarev <yury@upbound.io>
@natereid72 @ytsarev
Update docs/guides/argo-cd-crossplane.md
d321d3b 
Co-authored-by: Yury Tsarev <yury@upbound.io>
@natereid72 @ytsarev
Update docs/guides/vault-as-secret-store.md
0dca1f1 
Co-authored-by: Yury Tsarev <yury@upbound.io>
@natereid72 @ytsarev
Update docs/guides/vault-as-secret-store.md
92be92f 
Co-authored-by: Yury Tsarev <yury@upbound.io>
@negz negz merged commit 44d35eb into crossplane:master Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Backport failed for release-1.9, because 1 or more of the commits are not available.

Please cherry-pick the changes locally.
Note that rebase and squash merges are not supported at this time.
For more information see korthout/backport-action#46.

@negz
Copy link
Member

negz commented Sep 2, 2022

@natereid72 Since you had signed some of your commits I used GitHub's "Squash and Merge" functionality to squash them into one big signed commit.

negz pushed a commit to negz/crossplane that referenced this pull request Nov 4, 2022
@natereid72 @ytsarev @negz
add argo cd guide (crossplane#3041)
812808a 
* Add ArgoCD guide

Signed-off-by: natereid72 <natereid@protonmail.com>
Co-authored-by: Yury Tsarev <yury@upbound.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negz negz negz left review comments

@ytsarev ytsarev ytsarev approved these changes

@turkenh turkenh Awaiting requested review from turkenh turkenh is a code owner automatically assigned from crossplane/crossplane-maintainers

Assignees
No one assigned
Labels
backport release-1.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XRC -> XR Label Propagation Confuses ArgoCD
3 participants
@natereid72 @ytsarev @negz